OpenFactorioServerManager / factorio-server-manager

A tool to help manage Factorio multiplayer servers including mods and save games.
MIT License
557 stars 133 forks source link

Preserve IP and port binding when starting factorio game server #402

Open Squelch opened 2 months ago

Squelch commented 2 months ago

Ont he Controls page, the IP binding is set to all interfaces (0.0.0.0) by default for the factorio game server. This may have security or other unwanted affects on the host server. Whilst it is possible to enter an appropriate address on the Controls page, this is not preserved for subsequent use.

It is possible to change the defaults by editing the configuration, but this assumes a game admin has file permissions and shell access, and in the case of a docker instance, is rather convoluted.

It would be preferable if the binding and/or port used to launch factorio game server could be saved to the configuration file.

Mattie112 commented 2 months ago

Saving it sounds good, but the default of "0.0.0.0" seems reasonable for me. I mean it is a server after all so listening on all interfaces would be better then using a random one.

(I always listen on everything, preferably also on IPv6)

Squelch commented 2 months ago

The default of 0.0.0.0 is indeed useful, but there may be instances, say a hyperthetical, multple instances of factorio server on the same host. eg a LAN only private instance and another public facing game that are isolated from each other on thier own subnets or VLANs. Specifying the IP to which these are associated simplifies setup without them fighting over the same interface.

The suggestion is simply to preserve the IP and port numbers for a particular instance of server manager when entered into the launch game fields.

knoxfighter commented 2 months ago

And that suggestion i will follow, i thought about that as well, when i fixed those parts. The IP and Port should be saved, but the default of 0.0.0.0 will stay.

Mattie112 commented 2 months ago

Yes that seems the best option :)