search

OpenFactorioServerManager / factorio-server-manager

A tool to help manage Factorio multiplayer servers including mods and save games.
MIT License
556 stars 131 forks source link

Changing Visibility via the Game Configuration Settings breaks server #70

Closed CdrKeen closed 6 years ago

CdrKeen commented 7 years ago

if you change it from the config itself its fine, but if you look at the text field for visibility it displays [object Object] i think this is what is causing the issue. When you update the configuration it will no longer start the server and complain that there is an issue with the Syntax in Visibility. visibility

sdobz commented 7 years ago

Visibility changed from 'public'/'lan' to {'public':true/false, 'lan': true/false}

The docker version seems to overwrite this every time, I can't start the server

zigarot commented 7 years ago

yeah I'm getting this issue as well it adds quotations around the point, rendering the instructions inert, as well as adding escapes to quotations that I place manually.

marchingphoenix commented 6 years ago

found a workaround by specifically mapping the config file as read only via a -v option in my docker run command

docker create --name factorio-manager \
        --restart=always \
        --privileged=true \
        -e PGID=1000 -e PUID=1000  \
        -v /etc/localtime:/etc/localtime:ro \
        -v /docker/containers/factorio-manager/factorio/saves:/opt/factorio/saves \
        -v /docker/containers/factorio-manager/factorio/mods:/opt/factorio/mods \
        -v /docker/containers/factorio-manager/factorio/config:/opt/factorio/config \
        -v /docker/containers/factorio-manager/factorio/server-settings.json:/opt/factorio/config/server-settings.json:ro \
        -v /docker/containers/factorio-manager/security:/security \
        -p 443:443 -p 34197:34197/udp \
        majormjr/factorio-server-manager
mroote commented 6 years ago

fixed in 0.7.1