search

OpenFactorioServerManager / factorio-server-manager

A tool to help manage Factorio multiplayer servers including mods and save games.
MIT License
556 stars 131 forks source link

Unable to add admins on the Game Configuration Page #85

Closed kjablonski closed 6 years ago

kjablonski commented 6 years ago

I was trying to add myself as an Admin and after I add my username and restart the server, I get the following error:

0.000 Error Util.cpp:62: Value must be a list or dictionary in property tree at ROOT.admins 2017/11/27 13:38:20 [0.000 Error Util.cpp:62: Value must be a list or dictionary in property tree at ROOT.admins]

FSM version: 0.6 factorio version: 0.15.37

apdjz commented 6 years ago

what commands are you doing and show the game config page

Finkregh commented 6 years ago

Same problem here, when i add an admin the generated config contains "admins": "foo", but should contain "admins": ["foo"]

mroote commented 6 years ago

I can reproduce this issue, I think as a workaround you can just enter the admins value as an array ["admin_user"].

I'm working on fixing a few bugs with the settings form for the next release including this one so hopefully I'll have a fix soon.

Finkregh commented 6 years ago

that wont work, as things will be escaped :)

this is also an issue at "Visibility" and "Tags"

dgw commented 6 years ago

Yep, noted while trying to get my server up again for 0.16. The settings form likes to force things to string format, even if they look like lists/arrays, so you end up with things like "admins": [\"username\"] in the JSON. Having other issues relating to connectivity with Factorio itself, too, which doesn't help testing.

shark-net commented 6 years ago

Are there any usable workarounds for this? I can't start a server at all anymore.

dgw commented 6 years ago

re: workaround, Edit the server-settings file manually after configuring everything else with the webUI, I guess.

shark-net commented 6 years ago

I tried this, but starting the server from the webUI seems to overwrite any manual changes to the config files

mroote commented 6 years ago

Sorry for the delay with this bug. I think I have a fix now and have made a new version (0.7.1) which should hopefully fix it. If you could give that a test and see if it's working for you that would be great.

shark-net commented 6 years ago

I pulled the latest version, seems to have the exact same issue.

shark-net commented 6 years ago

Oops!! Its working. I Just needed to rebuild the dockerfile with the 0.7.1 env var. Thanks!

mroote commented 6 years ago

I've updated the dockerfile with the new version so you can pull the latest container once the build finishes.