search

OpenFastPath / ofp

OpenFastPath project
BSD 3-Clause "New" or "Revised" License
351 stars 126 forks source link

OFP update vs. odp? #233

Closed bogdanPricope closed 4 years ago

bogdanPricope commented 4 years ago

Any plan to update OFP to support odp 1.23?

psavol commented 4 years ago

Did you have a specific problem with the latest ODP?

I just built OFP with latest ODP master. ODP configure needs to include --enable-deprecated. However, OFP does not link correctly when ODP uses DPDK. We'll fix that shortly.

bogdanPricope commented 4 years ago

As far as I know, v1.23.0.0_DPDK_18.11 and v1.23.0.0 are the latest tags on odp-dpdk/odp repos. It makes sense (for OFP) to switch to latest ODP (odp-dpdk) 'release' version.

I am running ofp with odp-dpdk .. I am not aware of the issues from the main repo(sorry).

bogdanPricope commented 4 years ago

I mean, OK, we can build ODP with '--enable-deprecated' and add Matias's PR to fix the linking issues with 'ipv4_fwd' (and it builds) but will not be more appropriate (from OFP point of view) to actually update the ofp code to work with latest version (tag) of ODP? The changes are trivial as far as I understand (https://github.com/bogdanPricope/ofp/commit/b46a71403ffca2cdd6b93e9882cec510718b7ac6).

By the way, I am contributing as 'independent contributor' and I am no longer with Enea. So, those are only my opinions.

MatiasElo commented 4 years ago

Hi Bogdan,

As you said the required changes to support the latest ODP version seem to be quite trivial. I already have a "working" but untested branch in my local private repo. Hopefully I'll have enough time next week to finish the patch set.

bogdanPricope commented 4 years ago

Nice. Thank you, Matias.

Have a nice weekend.

MatiasElo commented 4 years ago

@bogdanPricope I've now posted a PR (#236) to enable OFP usage with the latest ODP code. Comments are appreciated if you have time.

bogdanPricope commented 4 years ago

Hi Matias, I'll have a look in the following hours. Best regards,

MatiasElo commented 4 years ago

Hi Matias, I'll have a look in the following hours. Best regards,

Thanks!