search

OpenFastPath / ofp

OpenFastPath project
BSD 3-Clause "New" or "Revised" License
349 stars 126 forks source link

Update CLI #238

Closed bogdanPricope closed 4 years ago

bogdanPricope commented 4 years ago

Update commands 'show', 'help', 'sysctl'. Add static arp.

MatiasElo commented 4 years ago

This is really useful commit for quick testing. Before I can merge the patch you should fill the OFP Contribution Agreement and send it to me. You can simply leave the Corporation part empty.

There are still quite a few checkpatch warnings which should be fixed. Some of the warnings can be ignored due to following the particular file's coding style.

sovu commented 4 years ago

@matiaselo OFP Contribution Agreement for Bogdan was sent and you can find it with the other CLAs.

bogdanPricope commented 4 years ago

I'll have a look tomorrow. I'm learning French and taking interviews... not much time for this.

MatiasElo commented 4 years ago

@matiaselo OFP Contribution Agreement for Bogdan was sent and you can find it with the other CLAs.

OK

MatiasElo commented 4 years ago

Excluding the few remaining code alignment problems patch is looking good.

bogdanPricope commented 4 years ago

Ok, ok... I was missing the '.checkpatch.conf'.

MatiasElo commented 4 years ago

Looking good. Please add the 'reviewed-by' tags to the commits and I'll merge them.