search

OpenFastPath / ofp

OpenFastPath project
BSD 3-Clause "New" or "Revised" License
349 stars 126 forks source link

Configure socket parameters at start time #248

Closed bogdanPricope closed 4 years ago

bogdanPricope commented 4 years ago

Add configuration at start time for the maximum number of sockets and socket number offset.

JannePeltonen commented 4 years ago

I think the way the changes are split to individual commits requires some rework. Each commit should be self-sufficient and leave the code base in a consistent state without assuming anything about subsequent commits.

The first commit introduces config API additions without the underlying functional changes. It could be combined with subsequent commits but I am fine with leaving it as it is (maybe with an improved commit message that tells that the does not work yet).

The second commit breaks make check as it does not adjust ofp_test_syscalls, which is done by the very last patch. This should be fixed. In addition, the second commit parameterizes OFP_SOCK_NUM_OFFSET only partially, leaving the netwrap out (done in the fourth commit). The change of OFP_SOCK_NUM_OFFSET to a configuration parameter should be done in one commit (with help of preparatory commits if needed) to have the whole code base consistent after each and every commit.

See additional comments within the individual commits.

bogdanPricope commented 4 years ago

Maybe I was too ambitious. Not many are.