Remove deprecated field to fix compiling

OpenFastPath / ofp

OpenFastPath project

BSD 3-Clause "New" or "Revised" License

349 stars 126 forks source link

Remove deprecated field to fix compiling #269

Closed AlejandroFuster closed 3 years ago

AlejandroFuster commented 3 years ago

With the release of ODP v1.29.0.0, the packet IO statistics field odp_pktio_stats_t.in_unknown_protos got deprecated. Since OFP uses this field, it fails to compile with the latest version. I removed it so I could compile OFP with the lastest ODP version.

bogdanPricope commented 3 years ago

Yes... but why (using ODP 1.29.0)? OFP does not use any of the new feature of ODP? I am running with 1.25.2.0. Anyway, there is no active reviewer...

AlejandroFuster commented 3 years ago

Yes... but why (using ODP 1.29.0)? OFP does not use any of the new feature of ODP? I am running with 1.25.2.0.

I tried the latest version before finding your fork, after reading the readme of OFPgen2 I started using v1.25.2.0 too, with better results! Thank you so much!

Anyway, there is no active reviewer...

Yes, I also realized that (sadly) after opening the PR... What a pity

Thank you so much @bogdanPricope, most of your answers in the issues here helped me a lot to get started!!

bogdanPricope commented 3 years ago

Thank you @AlejandroFuster. Now I know by name all the visitors of my fork repository.