OpenFeign / feign-annotation-error-decoder

Apache License 2.0
51 stars 9 forks source link

Dont work use global interface #10

Closed FelipeRodrigues21 closed 5 years ago

FelipeRodrigues21 commented 5 years ago

Hi, I'm using the annotation and I had a big problem, when I create a unique interface and try to extend it in other interfaces does not work.

saintf commented 5 years ago

Let me give that a try (basically... The annotations aren't necessarily inherited).

I can try to make the change to support inheritance.

On Wed, 6 Feb 2019, 20:13 FelipeRodrigues21 <notifications@github.com wrote:

Hi, I'm using the annotation and I had a big problem, when I create a unique interface and try to extend it in other interfaces does not work.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OpenFeign/feign-annotation-error-decoder/issues/10, or mute the thread https://github.com/notifications/unsubscribe-auth/ANOpiu2VQ5WSwZG9lp70AQGE_5gtXJ_xks5vKylvgaJpZM4al6rC .

FelipeRodrigues21 commented 5 years ago

Ok, thanks.

saintf commented 5 years ago

@FelipeRodrigues21 can you check the changes under https://github.com/saintf/feign-annotation-error-decoder/commit/2768e45d8c0de9927d8a42f65a46a07f57ad229f and see if they make sense to you/provide any feedback (changes/etc).

It "supports" inheritance (although annotation inheritance for interfaces isn't supported by java - but I can completely get if you want to have a base interface that defines the usual 4**'s and makes the exceptions fairly unified accross).

If that looks good, I'll look at pulling into the new version (which also upgrades us to 10.** series of feign)

saintf commented 5 years ago

@FelipeRodrigues21 actually - would be better if you can review the PR (https://github.com/OpenFeign/feign-annotation-error-decoder/pull/17). If all good, then I can merge and look to release.

saintf commented 5 years ago

merged and released. You should find from 1.1.1 the annotation is "inherited". Details in the documentation. enjoy!