OpenFeign / feign-annotation-error-decoder

Apache License 2.0
51 stars 9 forks source link

Upgrade to Feign 10.10.x #32

Open StefanFellinger opened 4 years ago

StefanFellinger commented 4 years ago

Ok as i can see, you have already migrated the minor api change. When do you think the 1.3.1 will be released?

StefanFellinger commented 4 years ago

Hey @saintf ,

is it possible, that you release the actual master branch? I like to update Feign and it seems to me, that the required changes are already in master branch.

Have a nice day.

MariusKl commented 4 years ago

Hi @saintf,

our team faces the same problem with the newest version of spring-cloud-starter-openfeign for which feign-annotation-error-decoder is not compatible with.

An attempt was made to call a method that does not exist. The attempt was made from the following location:
    feign.error.ExceptionGenerator.<clinit>(ExceptionGenerator.java:44) 

The following method did not exist:
    'feign.Request feign.Request.create(feign.Request$HttpMethod, java.lang.String, java.util.Map, feign.Request$Body)'

Could you please provide a new release? Thank you!

saintf commented 4 years ago

Working on it. I need to re-encrypt/re-authorise so that the automated process can release and push to maven central/etc. Should be done soon.

StefanFellinger commented 4 years ago

Hi @saintf ,

still issues with maven central? Is there any way we can support?

Have a nice day.

saintf commented 4 years ago

Gah. I have a new laptop and all the keys were reset and I have to install old packages. Hahahaha it's pain I have to go through and unfortunately requires my authentication. Otherwise I'd happily delegate. The other option would be for you to go through the pain of getting all the right access (JFrog, etc) so your creds would work and then you could do it.

So - I'm happy to finish it, it just takes longer than I planned on for it.

But medium/longer term - @StefanFellinger given you've contributed a bit more - do you want to get all the grants/etc and we pair up on this? I'd guide you on getting all the creds anyway as well so there's always two of us who can release this/review pull requests if necessary/etc.

Thanks!

On Wed, 30 Sep 2020, 07:29 StefanFellinger, notifications@github.com wrote:

Hi @saintf https://github.com/saintf ,

still issues with maven central? Is there any way we can support?

Have a nice day.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenFeign/feign-annotation-error-decoder/issues/32#issuecomment-701164541, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADJ2TCQCYHMW5PWYILHCMQ3SIK62TANCNFSM4NTPM6ZA .

StefanFellinger commented 4 years ago

Sounds good. Let's find a time slot maybe in november or december when everyone slows down a bit (hopefully), having time to play around with technology. At the moment i'm looking for tubular mushrooms like boletus before/after work, not doing so much on my pc within the free time ;-)

Boma commented 4 years ago

Hi guys, how it looks with the update in maven central? I would like to update several microservices to use the new version and work with Feign 10. Do you think this will happend in the next few days or later?

King Regards, Boris

jplatasv commented 4 years ago

Hi!

We are also expecting this update. I hope you've been able to sort out those authorization things you've got pending.

Thanks in advance for your time,

JP

jrmcdonald commented 3 years ago

Hi,

Has there been any progress on getting set up again to publish 1.4.0 to maven central? Trying to decide whether to use feign 9.7.x or feign 10.x.x for a project.

Cheers!

christian-kocke commented 3 years ago

Hi,

I would also be very interested in the new release to be able to use feign 10.10.x

Kind regards, Christian

HeshamOsman commented 3 years ago

Hi, It will be very helpful if 1.4.0 will be pushed to maven central.

Kind regards,

sebeard commented 3 years ago

Looks like this repo may be getting merged into core Feign at some point in the near future.

https://github.com/OpenFeign/feign/issues/1447