search

OpenFeign / feign-reactive

Reactive Streams Specification compatible implementation of Feign
Apache License 2.0
48 stars 11 forks source link

Add RxJava2 Support #12

Open kdavisk6 opened 6 years ago

kdavisk6 commented 6 years ago

Similar to Reactive, we should support RxJava2 and their Streams implementation.

kptfh commented 6 years ago

What about to wrap Reactor core implementation with reactor.adapter.rxjava.RxJava2Adapter to provide RxJava2 types support? Will it work for Android clients?

kdavisk6 commented 6 years ago

That is one approach to this, but wouldn't that require both reactor and rxjava2 to work?

With regards to Android, rxjava2 is recommended, but reactor should work if the SDK version is higher than 26. See Reactor Prerequisites

If we want to support Android, I think we should keep rxjava2 and reactor explicitly separate.

kptfh commented 6 years ago

From my side I can offer to follow (and may try to implement) this approach (wrapper over Reactor) as not sure how fast pure RxJava2 version will be implemented (guess it may take years :( ).

kdavisk6 commented 6 years ago

We can help with that. These issues are not tasks for you to take on, only to keep track of what I think would be good features for use to consider.