OpenFeign / feign

Feign makes writing java http clients easier
Apache License 2.0
9.51k stars 1.93k forks source link

Undefined value in @QueryMap params works not as described #1505

Open niktsar opened 3 years ago

niktsar commented 3 years ago

Here is description of behavior for undefined values https://github.com/OpenFeign/feign/blob/master/README.md#undefined-vs-empty-values

When I try to call client like this:

Map<String, Object> parameters = new LinkedHashMap<>();
parameters.put("param", null);
this.demoClient.test(parameters);

URL looks like /demo/client/url?param

Up to readme description, here https://github.com/OpenFeign/feign/blob/248871dede1a00afab14dd12c0f18383aa10462e/core/src/main/java/feign/ReflectiveFeign.java#L300 need to add filter of null values. Could you please confirm is it bug, or I misunderstand the description?

mroccyen commented 2 years ago

Passed the test, i think that it is a bug.

image

image