Closed chao-chang-paypay closed 1 year ago
Setting the root cause(e.g. SocketTimeoutException ) as the tag value might be more helpful than the exception in feign layer(e.g. RetryableException)
SocketTimeoutException
RetryableException
https://github.com/OpenFeign/feign/blob/5b8cd4a1e7d1e3a0ab09002a84351369acd8ddd6/micrometer/src/main/java/feign/micrometer/FeignMetricTagResolver.java#L52
That makes a lot of sense, feel free to make a PR for this change.
Cheers,
Setting the root cause(e.g.
SocketTimeoutException
) as the tag value might be more helpful than the exception in feign layer(e.g.RetryableException
)https://github.com/OpenFeign/feign/blob/5b8cd4a1e7d1e3a0ab09002a84351369acd8ddd6/micrometer/src/main/java/feign/micrometer/FeignMetricTagResolver.java#L52