search

OpenFeign / feign

Feign makes writing java http clients easier
Apache License 2.0
9.5k stars 1.93k forks source link

Can we set the root cause of exception in metrics? #1882

Closed chao-chang-paypay closed 1 year ago

chao-chang-paypay commented 1 year ago

Setting the root cause(e.g. SocketTimeoutException ) as the tag value might be more helpful than the exception in feign layer(e.g. RetryableException)

https://github.com/OpenFeign/feign/blob/5b8cd4a1e7d1e3a0ab09002a84351369acd8ddd6/micrometer/src/main/java/feign/micrometer/FeignMetricTagResolver.java#L52

velo commented 1 year ago

That makes a lot of sense, feel free to make a PR for this change.

Cheers,