search

OpenFeign / querydsl

Unified Queries for Java
https://querydsl.com
Apache License 2.0
260 stars 39 forks source link

Fix AbstractR2DBCQuery Fetch Method #490

Closed xeounxzxu closed 3 months ago

xeounxzxu commented 4 months ago

Changed to explicitly cancel R2DBC connection pool

@velo

issue number : https://github.com/OpenFeign/querydsl/issues/352

background :

This code gets the db connection via getConnection and performs operations within flatMapMany.

as-is: However, there is no explicit connection termination in the current version. There is no code to return to the connection pool, which can result in a resource leak.

to-be: Use Flux.usingWhen to acquire a connection, and when done, call the (Connection::close) method to close the connection and return. Because this method explicitly closes the connection, we've changed the resource management to allow for safe termination.

velo commented 3 months ago

For now, going to close this as tests are no passing.

xeounxzxu commented 3 months ago

@velo Sorry for the late reply. I will upload it again after changing the test case.