Hardcoded Application ID

OpenFlutter / flutter_share_me

Flutter Plugin for sharing contents to social media. You can use it share to Facebook , WhatsApp , Twitter And System Share UI. Support Url and Text.

https://github.com/lizhuoyuan

Apache License 2.0

151 stars 146 forks source link

Hardcoded Application ID #5

Closed nodinosaur closed 5 years ago

nodinosaur commented 5 years ago

DO NOT USE THIS LIBRARY UNTIL THESE ISSUES ARE FIXED

There is a hard coded application ID. FlutterShareMePlugin.java Line 136

Please review flutter_facebook_login

On how you should be handling this.

nodinosaur commented 5 years ago

The Application ID has also been hard coded into the Android Manifest: AndroidManifest.xml Line 7

DO NOT USE THIS LIBRARY UNTIL THESE ISSUES ARE FIXED

lizhuoyuan commented 5 years ago

AndroidManifest.xml Line 7

Do you mean this?

nodinosaur commented 5 years ago

OK, that is part of it... and the rest please

Also, look into how to run Mac OS X in a VM so you can run Xcode and iOS simulator, incomplete libraries should not even be listed on https://pub.dartlang.org/packages

lizhuoyuan commented 5 years ago

thanks for your suggestion