search

OpenFn / adaptors

The new home for OpenFn adaptors; re-usable connectors for the most common DPGs and DPI building blocks.
GNU General Public License v3.0
6 stars 8 forks source link

`mssql`: Credential investigate on lightning #630

Closed mtuchi closed 2 months ago

mtuchi commented 3 months ago

Description

If you use the mssql credential on lightning it enforce you to use encrypt and trusted certificate. I need to investigate further why this is happening.

aleksa-krolls commented 3 months ago

From Mtuchi: I think the bug i am experiencing using mssql credential was suppose to be fixed with this PR https://github.com/OpenFn/adaptors/pull/512, But something is still not right with mssql credential

mtuchi commented 3 months ago

This PR https://github.com/OpenFn/adaptors/pull/512 was for solving the credential issue

mtuchi commented 2 months ago

Okay after a throughly investigation i discovered two things

  1. The configuration-schema for mssql adaptor is missing a title for port property, See the fix #667
  2. The default values in the configuration-schema are not picked up by lightning on credential form. This is why i was getting an error saying Server requires encryption, set 'encrypt' config option to true. while i know for a fact that mssql adaptor set the encrypt option to true by default. I have already sync with @elias-ba and created an issue on lightning https://github.com/OpenFn/lightning/issues/2255

@aleksa-krolls