OpenFn / kit

The bits & pieces that make OpenFn work. (diagrammer, cli, compiler, runtime, runtime manager, logger, etc.)
10 stars 9 forks source link

worker isn't running NODE_ENV=production ? #651

Open josephjclark opened 6 months ago

josephjclark commented 6 months ago

The worker environment isn't running with NODE_ENV set to production.

This isn't neccessarily a problem, but it does mean that Lightning is printing deprecation notices on the old common.http helpers. It shouldn't really be doing that - the deprecation notice is designed only to come out in the CLI because the message is targeted at adaptor writers. Job writers can't do anything about it.

Probably the main worker server is running in prod mode, but the nested child process worker environment isn't inheriting it.

Maybe its even the sandbox - the sandbox, very deliberately, doesn't inherit the parent env. But maybe we should pipe NODE_ENV through.