update lightning plan options to use snake_case - Githubissues

OpenFn / kit

The bits & pieces that make OpenFn work. (diagrammer, cli, compiler, runtime, runtime manager, logger, etc.)

8 stars 12 forks source link

update lightning plan options to use snake_case #678

Closed midigofrank closed 2 months ago

midigofrank commented 2 months ago

Short Description

Updates the runTimeoutMs key to run_timeout_ms
Adds a future option: run_memory_limit

Related issue

Fixes #677

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I have added unit tests
[x] Changesets have been added (if there are production code changes)

Release branch checklist

If this IS a release branch:

[x] Run pnpm changeset from root to bump versions
[x] Run pnpm install
[x] Commit the new version numbers
[x] Run pnpm changeset tag to generate tags
[x] Push tags git push --tags

Tags may need updating if commits come in after the tags are first generated.

midigofrank commented 2 months ago

Looks good @midigofrank ! Nice and simple.

Although it's technically a breaking change, it's such a small one, and on an unused feature. It feels more like a patch to me? What do you think?

You can just update the changelog file to adjust it

Yeah, given it's an unused feature, a patch is sounds right

midigofrank commented 2 months ago

@josephjclark should I create the tag and push? EDIT: I have pushed the tags