OpenFn / kit

The bits & pieces that make OpenFn work. (diagrammer, cli, compiler, runtime, runtime manager, logger, etc.)
8 stars 12 forks source link

Runtime: remove the default timeout #691

Closed josephjclark closed 1 month ago

josephjclark commented 1 month ago

In the Worker, the runtime is currently always defaulting the timeout to its own native default.

This is confusing and misleading and wrong and will cause an early exit if the run timeout is longer than the default runtime timeout.

This PR:

Quick note as well at the engine used to pass in timeout:0 to the runtime to disable the default - but that actually just wasn't working since I moved the timeout to the plan options.

This is not well tested - I suggest we add a bunch of tests around this in #414