search

OpenFn / kit

The bits & pieces that make OpenFn work. (diagrammer, cli, compiler, runtime, runtime manager, logger, etc.)
8 stars 12 forks source link

Worker: better error messages on credentials #692

Open josephjclark opened 1 month ago

josephjclark commented 1 month ago

When the worker fails to load a credential, it'll just log a generic error message.

We need to ensure that if Lightning returns an error on the credential, that the error makes it back to the run logs.

As part of this issue, I also want to make sure we've got good unit and integration tests around this area (at a quick look it seems not too bad)

See https://github.com/OpenFn/lightning/issues/1842

josephjclark commented 1 month ago

One fun thing here is that this happens before the run technically starts. It's part of the lost logs without a step id. I think lightning will just ignore it.

Anyway, so long as we throw a better error message out of the credential loader, we'll show the message as the exit reason and everything will be fine.