return 403 when limiter returns error during provisioning

midigofrank commented 3 weeks ago

Validation Steps

Check: https://github.com/OpenFn/thunderbolt/pull/182

Review checklist

[x] I have performed a self-review of my code
[x] I have verified that all appropriate authorization policies (:owner, :admin, :editor, :viewer) have been implemented and tested
[x] If needed, I have updated the changelog
[ ] Product has QA'd this feature

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.63%. Comparing base (82e6c19) to head (56cad97).

:exclamation: Current head 56cad97 differs from pull request most recent head 7d3f790

Please upload reports for the commit 7d3f790 to get more accurate results.

Files	Patch %	Lines
lib/lightning_web/views/error_view.ex	50.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2182 +/- ## ========================================== - Coverage 89.64% 89.63% -0.01% ========================================== Files 270 270 Lines 9007 9009 +2 ========================================== + Hits 8074 8075 +1 - Misses 933 934 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stuartc commented 3 weeks ago

@midigofrank thanks for this, I made a small change where the controller is responsible for making the assigns for the view function, instead of making another match in the ErrorView.

OpenFn / lightning