OpenFn / lightning

OpenFn/Lightning ⚡️ is the newest version of the OpenFn DPG and provides a web UI to visually manage complex workflow automation projects.
https://openfn.github.io/lightning/
GNU Lesser General Public License v3.0
115 stars 31 forks source link

Fix race condition when syncing from openfn while deploy actions are running #2204

Closed midigofrank closed 1 week ago

midigofrank commented 1 week ago

Validation Steps

In order to test this properly, your github project should have more than 1 connection to openfn. Let's go with 2

Related issue

Fixes #2179

Review checklist

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.70%. Comparing base (40c8715) to head (2245451).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2204 +/- ## ======================================= Coverage 89.70% 89.70% ======================================= Files 275 275 Lines 9039 9039 ======================================= Hits 8108 8108 Misses 931 931 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

midigofrank commented 1 week ago

Oops! https://taurit.pl/github-canceling-since-a-higher-priority-waiting-request-exists/

midigofrank commented 1 week ago

This doesn't fix the issue. It will cancel pending workflows. See: https://github.com/midigofrank/openfn/actions/runs/9542614901