Reverted behaviour on "Rerun from here" to select the Log tab.

OpenFn / lightning

OpenFn/Lightning ⚡️ is the newest version of the OpenFn DPG and provides a web UI to visually manage complex workflow automation projects.

https://openfn.github.io/lightning/

GNU Lesser General Public License v3.0

115 stars 31 forks source link

Reverted behaviour on "Rerun from here" to select the Log tab. #2215

Closed stuartc closed 4 days ago

stuartc commented 4 days ago

Validation Steps

When inspecting an existing Run, ensure you have any tab other than 'Logs' selected.
Click "Retry from here"
The Logs tab should be selected

Related issue

Fixes #2202

Review checklist

[x] I have performed a self-review of my code
[x] I have verified that all appropriate authorization policies (:owner, :admin, :editor, :viewer) have been implemented and tested
[x] If needed, I have updated the changelog
[x] Product has QA'd this feature

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.68%. Comparing base (b61626d) to head (e74946f).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2215 +/- ## ========================================== - Coverage 89.69% 89.68% -0.02% ========================================== Files 275 275 Lines 9055 9055 ========================================== - Hits 8122 8121 -1 - Misses 933 934 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

taylordowns2000 commented 4 days ago

@stuartc , fyi i didn't like overriding the default behaviour without actually thinking through the implications. i'm using the current (working nicely) implementation where a link with #log at the end will focus the logs tab.

from run view:

from history