Closed stuartc closed 2 days ago
Attention: Patch coverage is 28.30189%
with 76 lines
in your changes missing coverage. Please review.
Project coverage is 88.93%. Comparing base (
9423bd7
) to head (c1708f5
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
- When clicking "run" from the middle panel, I notice that the AI chat panel gets wiped clear. (I also notice that the input panel flashes unexpectedly and then comes back.) Can you look into this?
@stuartc I think the chat gets cleared because the update
callback of the LiveComponent
gets called after the LiveView
handle_params
and that creates a new session.
I think we really need an external place to cache the session history to shield the user from losing the history maybe due to a liveview crash or something we don't account for.
@midigofrank @taylordowns2000 I've fixed the wiping of the chat state on clicking run here: https://github.com/OpenFn/lightning/pull/2216/commits/8363a28bf9f17585d58ea37edf4a2bc702ad65f6
Validation Steps
OPENAI_API_KEY
, your OpenAI API key.APOLLO_ENDPOINT
, can usehttps://apollo.staging.openfn.org/
.Log in as a superuser, and go to edit a job - you should have the AI assistant menu item available.
Notes for the reviewer
There is no chat persistence between page navigation or reloads.
Related issue
Fixes #2193
Review checklist
:owner
,:admin
,:editor
,:viewer
) have been implemented and tested