Context: Flaky tests are more expensive than slow tests.
What's up:
689 introduces a 100ms sleep in two places to try to address a persistently flaky test.
Relying on Process.sleep() isn't great because it slows down our tests—in this case by 200ms per run.
But we think it's better than having this test flake once every 15 or 20 runs.
In other words, we've fixed this with Process.sleep for now to mitigate the impact of the flaky test on our devs, but there's gotta be a better solution.
Context: Flaky tests are more expensive than slow tests.
What's up:
689 introduces a 100ms sleep in two places to try to address a persistently flaky test.
Process.sleep()
isn't great because it slows down our tests—in this case by 200ms per run.In other words, we've fixed this with Process.sleep for now to mitigate the impact of the flaky test on our devs, but there's gotta be a better solution.