OpenFn / lightning

OpenFn/Lightning ⚡️ is the newest version of the OpenFn DPG and provides a web UI to visually manage complex workflow automation projects.
https://openfn.github.io/lightning/
GNU Lesser General Public License v3.0
131 stars 36 forks source link

Warn before closing a form with unsaved changes #780

Open taylordowns2000 opened 1 year ago

taylordowns2000 commented 1 year ago

Starting with the job builder because it's the most high-impact, we need an elegant and generic way to detect when a form has unsaved changes (maybe through the validate hook?) then then display a warning before the user closes.

This is particularly important on the job builder since clicking anywhere else on the canvas will close the form. See @josephjclark 's old https://github.com/OpenFn/Lightning/issues/280


NickOpenFn commented 1 year ago

Do in the next sprint, requires UI

NickOpenFn commented 1 year ago

Noting that this is badly spec'd for taking into the sprint

elias-ba commented 1 year ago

Technically blocked. See this question on the Elixir Forum.

NickOpenFn commented 1 year ago

Moving into backlog. When planned again will need a spike to look at alternatives.

taylordowns2000 commented 4 months ago

@stuartc , this also relates to #2007 ?

christad92 commented 3 months ago

@midigofrank's work on #2297 should help with this. Modals will not close by clicking outside them.

@midigofrank correct?

midigofrank commented 3 months ago

@christad92 yes and no. I don't think the modals in the workflow page uses the same component as the one in #2297. But we can use the same technique.