search

OpenFn / lwala

2 stars 3 forks source link

Update HH job shows false success when no records upserted in SF #45

Closed aleksa-krolls closed 3 years ago

aleksa-krolls commented 3 years ago

Overview

This issue has come up in other Lwala jobs before - see issue #23

Current Behavior

Update-Household-in-SF-Production.js job runs succeed and show green checks even when not all operations in the job are successfull. See run 10563364 as an example where OpenFn marks the run as successful, but the Household record in the run log was not successfully upload to Salesforce (no result returned in the log).

Request

Please troubleshoot and make the appropriate changes so that:

  1. OpenFn will not return a false "success" message when one of the job operations failed
  2. Household__c records are upserted correctly

Resources

state.json

Test with Lwala Sandbox. See LP for creds. Use this message to test: https://www.openfn.org/projects/185/messages/7226887

adaptor

Use language-salesforce and make use of this LP's FakeAdaptor for offline testing.

expression.js

Related to job Update-Household-in-SF-Production.js

output

Re-run this on prod to make sure a HH record is created: https://www.openfn.org/projects/185/runs/10563364

Toggl

Log your time to Lwala Cleanup 2020.

aleksa-krolls commented 3 years ago

@taylordowns2000 this unblocks me on troubleshooting something, so would be great to have this done today - whether you or mamadou.