search

OpenFn / lwala

1 stars 3 forks source link

add cooldown #87

Closed taylordowns2000 closed 1 year ago

taylordowns2000 commented 1 year ago

@aleksa-krolls suggested that maybe these requests are going too fast for Salesforce's API. If we're not in danger of running into OpenFn runtime limits (100s) then why not slow down the requests to Salesforce with a cooldown?

This is an attempt to fix #86

mtuchi commented 1 year ago

Not a bad idea but I think we added about 16 seconds to this job, Which does not include the query and the upserIf time I think it will take longer now to run this job approx 20s each time it's called So that means we will need to enable long execution time on platform app

@taylordowns2000

taylordowns2000 commented 1 year ago

@mtuchi , i don't think so: https://docs.openfn.org/documentation/jobs/errors/#2-timeout - with that standard 100s we've got plenty of buffer, no?

mtuchi commented 1 year ago

@mtuchi , i don't think so: https://docs.openfn.org/documentation/jobs/errors/#2-timeout - with that standard 100s we've got plenty of buffer, no?

Yap that's plenty of buffer, I am happy with this I guess we need @ritazagoni to test on platform-app

ritazagoni commented 1 year ago

Thanks guys, we'll test this on platform!