Modify gender data transformation

OpenFn / unicef-cambodia

UNICEF Cambodia - Primero Interoperability

https://openfn.github.io/unicef-cambodia/

1 stars 2 forks source link

Closed aleksa-krolls closed 4 years ago

aleksa-krolls commented 4 years ago

https://github.com/OpenFn/unicef-cambodia/blob/4ab6648ab61829ed454057b4d1c91eb78086afc5/jobs/f2-j2-upsertCasesToPrimero.js#L346 Here we need to... (1) Return a null value if the case was already registered in Primero to prevent data overwrites. c.external_id && c.external_id !== '' ? null : c.gender (2) AND return 'other' value if c.gender does not equal 'male', 'female', null, or ''. (This has been partly been implemented on L346.)

taylordowns2000 commented 4 years ago

never update the gender if there is an externalId
make sure this works with empty string as well as with undefined
after the externalID check, then if (c.gender not in ['male', 'female', '', undefined, null]) { 'other' } else { return the thing }