OpenFn / unicef-cambodia

UNICEF Cambodia - Primero Interoperability
https://openfn.github.io/unicef-cambodia/
1 stars 2 forks source link

remove oscarValues function, add 'isUpdate' key #64

Closed taylordowns2000 closed 3 years ago

taylordowns2000 commented 3 years ago

@aleksa-krolls , I've tested this locally but want your eyes on it as well. I think this is a more intuitive way to handle empty strings (testing them directly). Beyond that, each time we were using oscarValue(c.external_id) ? null : 'some value' i've opted for isUpdate ? null : 'some value' as it feels simpler for humans.