search

OpenFn / women-for-women

OpenFn integrations for BambooHR, MS Azure AD, and other systems
0 stars 1 forks source link

fix error lines, #108 #111

Closed grayey closed 2 years ago

grayey commented 2 years ago

This feature builds the error lines for duplicate emails.

taylordowns2000 commented 2 years ago

I think this is done @aleksa-krolls ... even including your last bit of feedback on Slack. That formatting was related to an old state and the mistake that we made during testing. If you test once more (the full flow, job 1 and job 2) and confirm it’s still a problem then I can fix it in a flash.

But, my recommendation now (since setting up the error state is tricky offline) is that you should merge the PR, then change the to: field and test it on production. When you’re happy on prod, then put back the to:. Let me know if you want me to help in this test flow.

aleksa-krolls commented 2 years ago

merged, thanks @grayey @taylordowns2000 :)