OpenFogStack / matterHub

(A)DSP: Lightweight matter Hub

MIT License

2 stars 0 forks source link

Automation for Mac #59

Closed Emirhan-Atabay closed 2 years ago

Emirhan-Atabay commented 2 years ago

Pull Request Checklist

Automates and simplifies the building process on Mac.

Author

[x] Built code and tested locally
[x] Removed any TODOs, etc.
[x] Metioned the issue this PR closes
[x] Good description of what the PR does written

Reviewer

[ ] Built and tested code locally
[ ] Fully understood the PR
[ ] All open conversations resolved

Emirhan-Atabay commented 2 years ago

53

TuCl commented 2 years ago

Comments:

sh file should be started from terminal not by "click" - Replace the "click" command accordingly.

"Type in yes or click enter" - this is confusing (it suggests that typing yes and clicking enter has the same functionality)

Errors:

23:84: execution error: „Terminal“ hat einen Fehler erhalten: „window 3“ kann nicht gelesen werden. (-1728) autostart process is completed!

I tried this inside VSCode Terminal, I will try again with Mac Terminal

TuCl commented 2 years ago

After clicking enter inside the Mac Terminal a new Window opens with this error:

cd .; source ./settings.sh; sh ./hub_start.sh source: no such file or directory: ./settings.sh sh: ./hub_start.sh: No such file or directory

cd .; source ./settings.sh; sh ./enddevice_start.sh source: no such file or directory: ./settings.sh sh: ./enddevice_start.sh: No such file or directory

Matterpath is set to export MATTERPATH="/Users/ctu/ADSP/matterHub" where the matterHub folder is the root of the GitHub project.

Emirhan-Atabay commented 2 years ago

Okay that should not actually be so. It does not recognize your settings.sh. I am thinking of a solution for this problem.

"sh file should be started from terminal not by "click"" I think that's easier for the users. You can start it from the terminal too. The users should decided it for their own.

Emirhan-Atabay commented 2 years ago

Do you tried to double click on autostart.sh without trying to start it with the Terminal? It's possible that bash don't like this command: BASEDIR=$(dirname "$0"). It's not working when you try to start it with the Terminal. Try this instead: Go to the autostart.sh file and right click on it, select open with Terminal. I think I should change that anyway so that you can open it with the Terminal too.

Emirhan-Atabay commented 2 years ago

Okay, it should work now!