OpenFreeEnergy / IndustryBenchmarks2024

Repository for the 2024 OpenFE industry benchmark efforts
https://industrybenchmarks2024.readthedocs.io/en/latest/
MIT License
1 stars 7 forks source link

Script to plan RBFE alchemical networks #31

Closed hannahbaumann closed 4 weeks ago

hannahbaumann commented 1 month ago

Input submission checklist

For each submitted directory:

Summary of changes

Licensing agreement

pep8speaks commented 1 month ago

Hello @hannahbaumann! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 10:80: E501 line too long (88 > 79 characters) Line 27:80: E501 line too long (82 > 79 characters) Line 70:80: E501 line too long (88 > 79 characters) Line 75:80: E501 line too long (85 > 79 characters) Line 208:80: E501 line too long (85 > 79 characters) Line 219:80: E501 line too long (80 > 79 characters) Line 220:80: E501 line too long (80 > 79 characters) Line 251:80: E501 line too long (81 > 79 characters)

Line 50:80: E501 line too long (83 > 79 characters) Line 56:80: E501 line too long (84 > 79 characters) Line 56:85: W291 trailing whitespace Line 61:80: E501 line too long (82 > 79 characters) Line 62:80: E501 line too long (82 > 79 characters) Line 75:80: E501 line too long (97 > 79 characters) Line 76:80: E501 line too long (82 > 79 characters) Line 78:80: E501 line too long (85 > 79 characters)

Comment last updated at 2024-06-11 08:59:25 UTC
IAlibay commented 4 weeks ago

Looks Good to me!

I think for the future, we should make more use of the alchemical network planners, or develop them further, sucht they are more useful. But this is not an issue for this time. Still would like to get feedback on those. @IAlibay @hannahbaumann

Yeah - this is definitely at the top of my mind as we plan out our next pieces of work.