OpenFreeEnergy / IndustryBenchmarks2024

Repository for the 2024 OpenFE industry benchmark efforts
https://industrybenchmarks2024.readthedocs.io/en/latest/
MIT License
1 stars 5 forks source link

industry-benchmarking-layout #72

Closed RiesBen closed 3 weeks ago

RiesBen commented 3 weeks ago

Hi, I think it would be great if our folder structure follows this here: https://docs.openfree.energy/en/stable/tutorials/rbfe_cli_tutorial.html

in my understanding the final folder structure, after full execution should look like this:

some_benchmark_folder

--network_setup -----ligand_network.graphml -----alchemical_network.json -----transformations -------*jsons

--results ----fun1 ------shared* --------nc -----fun1.json ----fun2 ------shared --------*nc -----fun2.json ---- ...

--final_results.tsv

IAlibay commented 3 weeks ago

@RiesBen

-----ligand_*json

Sorry for the silly question, but what is this? The alchemical network?

--results

I think the way we wanted to go was:

-- network_setup

Does that match what you envision?

hannahbaumann commented 3 weeks ago

I don't think I would put the results under network_setup since that seems confusing to me, but may just be me!

IAlibay commented 3 weeks ago

I don't think I would put the results under network_setup since that seems confusing to me, but may just be me!

Yes sorry! That should be separate

RiesBen commented 3 weeks ago

@IAlibay - file name of ligand_*json: ja my bad, I corrected that in the initial post

IAlibay commented 3 weeks ago

I've opened PR #76 with the aim of fixing this