OpenFreeEnergy / feflow

Recipes and protocols for molecular free energy calculations using the openmmtools/perses and Open Free Energy toolkits
MIT License
13 stars 1 forks source link

`NonEquilibriumCyclingProtocol` : Add ability to have multiple iterations/laps within a single `CycleUnit`? #66

Open dotsdl opened 2 months ago

dotsdl commented 2 months ago

Currently for the NonEquilibriumCyclingProtocol, one can increase the cycling sampling performed by a single ProtocolDAG by increasing the num_cycles setting. This causes the ProtocolDAG to feature as many CycleUnits as num_cycles, which generally works well for most use cases, and allows for DAG-level parallelism on executors that support this.

However, for some execution contexts, such as Folding@Home, this approach restricts us to performing a single CycleUnit per Folding@Home work unit (WU), which can cause problems for both volunteers and the system as a whole if these execute too quickly. Increasing the equilibrium_steps and nonequilibrium_steps may increase sampling up to some limit, but still may result in too-short simulation times for practical Folding@Home use.

We propose adding a positive integer setting num_cycle_iterations or num_cycle_laps to the NonEquilibriumCyclingProtocol that defaults to 1 giving current behavior, but when set to 2 or more results in additional iterations of cycling within each CycleUnit on the ProtocolDAG. This will need to be encoded in the OpenMM integrator generated by the SetupUnit to work properly, I think.

dotsdl commented 2 months ago

Let's hold off on actioning this until we've performed more live testing with Folding@Home using @jchodera's sampling suggestions. We'll know more from that activity as to how vital this feature will be for us.