OpenFreeEnergy / gufe

grand unified free energy by OpenFE
https://gufe.readthedocs.io
MIT License
32 stars 9 forks source link

External resource updates #257

Closed dwhswenson closed 11 months ago

dwhswenson commented 11 months ago

Two things here:

  1. Add equality checks for ExternalResources
  2. Fix a potential problem when storing a path for FileStorage into a nested directory.

These were part of the overall work I've been doing on StagingPaths and the bigger storage tasks, but this is a small, self-contained PR that can be reviewed pretty easily. I thought it might be easier to review this first.

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d8bc04e) 99.20% compared to head (4e286b2) 99.20%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #257 +/- ## ======================================= Coverage 99.20% 99.20% ======================================= Files 36 36 Lines 1893 1898 +5 ======================================= + Hits 1878 1883 +5 Misses 15 15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.