Open dwhswenson opened 11 months ago
Hello @dwhswenson! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
gufe/protocols/protocoldag.py
:Line 384:80: E501 line too long (82 > 79 characters) Line 385:80: E501 line too long (82 > 79 characters) Line 393:80: E501 line too long (80 > 79 characters)
gufe/tests/storage/test_stagingserialization.py
:
This is a subset of the work in #234, split off to facilitate review. This PR will merge into #186 (making it easier to see the additions specific to the PR, but meaning that this should be merged before that). It also includes the work in #257 (one of the old tests fails without that).
This PR integrates
StorageManager
intoexecute_DAG
. Note that this still isn't a complete replacement of the storage system: a follow-up PR will handle serialization ofStagingPath
s.TODO:
ReproduceOldBehaviorStorageManager
; I think some paths aren't quite right.ExecutionStorageDemoTest
subclassesdag_label
is given (also needed in #186)