OpenFreeEnergy / gufe

grand unified free energy by OpenFE
https://gufe.readthedocs.io
MIT License
28 stars 8 forks source link

improve 2d vis of mappings #278

Closed richardjgowers closed 8 months ago

richardjgowers commented 8 months ago

previously would independently calculate 2D vis for each molecule, then RMS align these

now constrains second molecule's 2d representation to match that of the first molecule

overall improves the 2d vis generated, esp. when dealing with rotamers

before: (here atom 9L maps to atom 9R. rdkit however assigns a more traditional sulfonamide layout)

image (3)

after: (atom 9L & 9R are constrained. This results in the H's having less layout room, but makes it clear why they didn't map)

mapping_fixed

pep8speaks commented 8 months ago

Hello @richardjgowers! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 135:80: E501 line too long (80 > 79 characters) Line 159:80: E501 line too long (80 > 79 characters)

Comment last updated at 2024-01-29 13:47:29 UTC
codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1f77481) 99.22% compared to head (1de370a) 99.22%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #278 +/- ## ======================================= Coverage 99.22% 99.22% ======================================= Files 36 36 Lines 1938 1942 +4 ======================================= + Hits 1923 1927 +4 Misses 15 15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.