OpenFreeEnergy / gufe

grand unified free energy by OpenFE
https://gufe.readthedocs.io
MIT License
28 stars 8 forks source link

Dep warnings for dict mapping #296

Closed richardjgowers closed 6 months ago

richardjgowers commented 6 months ago

smoothes over a change made in PR #260

pep8speaks commented 6 months ago

Hello @richardjgowers! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 180:80: E501 line too long (104 > 79 characters)

Line 336:80: E501 line too long (97 > 79 characters)

Line 127:80: E501 line too long (90 > 79 characters) Line 129:80: E501 line too long (80 > 79 characters) Line 136:80: E501 line too long (82 > 79 characters)

Line 28:80: E501 line too long (111 > 79 characters)

Comment last updated at 2024-03-13 11:28:55 UTC
codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.94%. Comparing base (4527364) to head (2d6db93).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #296 +/- ## ======================================= Coverage 98.93% 98.94% ======================================= Files 36 36 Lines 1978 1986 +8 ======================================= + Hits 1957 1965 +8 Misses 21 21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

richardjgowers commented 6 months ago

@mikemhenry Yeah I wasn't sure when we'd ever have to remove these lines. It's not that bad to keep in the shim for all of 1.x. If/when we find a reason this can't stay we can add a deprecation removal date in the message