OpenFreeEnergy / gufe

grand unified free energy by OpenFE
https://gufe.readthedocs.io
MIT License
28 stars 7 forks source link

Add tests for PR #265 #316

Open IAlibay opened 2 months ago

IAlibay commented 2 months ago

PR #265 introduced a change to the PDBFile -> RDKit conversion in ProteinComponent, including support for new ion types.

However, this PR did not include any new tests. Because it's a part of the code that can have a large impact on how our calculations behave, and because it has changed expected behaviour, we should really consider adding some tests.