OpenFreeEnergy / kartograf

This package contains tools for setting up hybrid-topology FE calculations
https://kartograf.readthedocs.io/
MIT License
25 stars 3 forks source link

Make atom and ring hybridization filters consistent #67

Open jthorton opened 1 week ago

jthorton commented 1 week ago
    Thanks, @jthorton , this looks good to me! 
    I just have one general question to this filter:
    Right now, this only removes / disallows mappings between an aromatic and aliphatic ring. 
    Would we also want to disallow mapping e.g. two aliphatic rings with different hybridization of some atoms (e.g. 
    cyclohexane and cyclohexene) or should those cases be handled in the atom hybridization change filter?

Originally posted by @hannahbaumann in https://github.com/OpenFreeEnergy/kartograf/pull/65#pullrequestreview-2442617139