pep8speaks
commented
6 months ago Hello @RiesBen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
- In the file
src/konnektor/network_planners/__init__.py:
Line 2:80: E501 line too long (92 > 79 characters) Line 7:80: E501 line too long (95 > 79 characters) Line 11:80: E501 line too long (99 > 79 characters)
Line 137:80: E501 line too long (88 > 79 characters) Line 174:9: E731 do not assign a lambda expression, use a def Line 196:17: E731 do not assign a lambda expression, use a def Line 283:13: E731 do not assign a lambda expression, use a def Line 294:17: E731 do not assign a lambda expression, use a def Line 296:17: E731 do not assign a lambda expression, use a def Line 296:38: E713 test for membership should be 'not in' Line 300:80: E501 line too long (80 > 79 characters)
- In the file
src/konnektor/network_planners/_networkx_implementations/n_nodes_edges_network_algorithm.py:
Line 38:13: E122 continuation line missing indentation or outdented Line 38:80: E501 line too long (80 > 79 characters)
Line 28:80: E501 line too long (87 > 79 characters) Line 76:80: E501 line too long (82 > 79 characters)
Line 59:9: E125 continuation line with same indent as next logical line
Line 26:1: E302 expected 2 blank lines, found 1 Line 29:18: E122 continuation line missing indentation or outdented Line 124:80: E501 line too long (82 > 79 characters) Line 141:80: E501 line too long (81 > 79 characters) Line 146:80: E501 line too long (80 > 79 characters)
Line 46:80: E501 line too long (80 > 79 characters) Line 56:80: E501 line too long (81 > 79 characters) Line 64:9: E125 continuation line with same indent as next logical line
Line 49:9: E125 continuation line with same indent as next logical line
Line 41:9: E125 continuation line with same indent as next logical line
Line 36:80: E501 line too long (81 > 79 characters) Line 44:9: E125 continuation line with same indent as next logical line Line 75:36: E741 ambiguous variable name 'l'
Line 40:80: E501 line too long (81 > 79 characters) Line 66:9: E125 continuation line with same indent as next logical line
- In the file
src/konnektor/network_planners/generators/redundant_minimal_spanning_tree_network_generator.py:
Line 41:80: E501 line too long (81 > 79 characters) Line 51:9: E125 continuation line with same indent as next logical line Line 100:40: E741 ambiguous variable name 'l'
Line 34:80: E501 line too long (81 > 79 characters)
Line 11:80: E501 line too long (106 > 79 characters) Line 38:80: E501 line too long (106 > 79 characters)
Line 7:80: E501 line too long (81 > 79 characters) Line 8:5: E128 continuation line under-indented for visual indent Line 9:5: E128 continuation line under-indented for visual indent Line 10:5: E128 continuation line under-indented for visual indent
Line 11:80: E501 line too long (81 > 79 characters) Line 78:80: E501 line too long (81 > 79 characters)
Line 85:69: E251 unexpected spaces around keyword / parameter equals Line 86:80: E501 line too long (80 > 79 characters)
Line 12:80: E501 line too long (81 > 79 characters) Line 92:80: E501 line too long (81 > 79 characters)
Line 10:80: E501 line too long (106 > 79 characters) Line 27:80: E501 line too long (95 > 79 characters) Line 30:80: E501 line too long (94 > 79 characters)
here, really separating out the generator refactoring.