OpenFreeEnergy / konnektor

Algorithms for various Network Layouts and Tooling for planning FE Calculations
https://konnektor.readthedocs.io/
MIT License
14 stars 3 forks source link

Refactor black #62

Closed RiesBen closed 3 months ago

RiesBen commented 3 months ago

This PR is reafactoring the whole Repo with Black, improving the code readability.

Depends on #58 , as has the same origin.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 90.13605% with 29 lines in your changes missing coverage. Please review.

Project coverage is 90.90%. Comparing base (193a55d) to head (af0a844). Report is 1 commits behind head on build_v1.

Files Patch % Lines
...work_planners/concatenators/cyclic_concatenator.py 0.00% 5 Missing :warning:
src/konnektor/visualization/widget.py 77.27% 5 Missing :warning:
src/konnektor/network_analysis/network_analysis.py 80.95% 4 Missing :warning:
...planners/generators/clustered_network_generator.py 82.35% 3 Missing :warning:
...tworkx_implementations/radial_network_algorithm.py 80.00% 2 Missing :warning:
...k_planners/generators/_parallel_mapping_pattern.py 66.66% 2 Missing :warning:
...erators/minimal_spanning_tree_network_generator.py 75.00% 2 Missing :warning:
...dundant_minimal_spanning_tree_network_generator.py 80.00% 2 Missing :warning:
src/konnektor/data/__init__.py 85.71% 1 Missing :warning:
...tworkx_implementations/cyclic_network_algorithm.py 97.50% 1 Missing :warning:
... and 2 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## build_v1 #62 +/- ## ============================================ - Coverage 91.10% 90.90% -0.21% ============================================ Files 46 46 Lines 1293 1308 +15 ============================================ + Hits 1178 1189 +11 - Misses 115 119 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

IAlibay commented 3 months ago

@RiesBen the correct approach is to squash merge when applying black to a codebase, that way you don't overwrite your entire history - is this what you did here and/or can you isolate the commit where you applied black so we can put it in the git ignore list?