search

OpenFreeEnergy / konnektor

Algorithms for various Network Layouts and Tooling for planning FE Calculations
https://konnektor.readthedocs.io/
MIT License
14 stars 3 forks source link

Are Network generators factories? #68

Open IAlibay opened 3 months ago

IAlibay commented 3 months ago

Usually I expect a Generator to have __iter__ defined, but the pattern used seems a lot closer to a factory pattern.

Would it make sense to not call it "Generator" to avoid Python confusion?

atravitz commented 3 weeks ago

In conversation with @RiesBen, we think that Creator might be a more accurate term. But there is a code example in the paper draft using Generator.

@IAlibay we are find with making this Generator -> Creator name change quickly before publishing. Any concerns?

RiesBen commented 3 weeks ago

In conversation with @RiesBen, we think that Creator might be a more accurate term. But there is a code example in the paper draft using Generator.

@IAlibay we are find with making this Generator -> Creator name change quickly before publishing. Any concerns?

After discussions, this is might be an interesting suggestion for the future. For now we will not follow up on this.