OpenFreeEnergy / openfe

The Open Free Energy toolkit
https://docs.openfree.energy
MIT License
135 stars 18 forks source link

don't test openfecli, it is flaky for some reason #831

Closed mikemhenry closed 5 months ago

mikemhenry commented 5 months ago

Checklist

Developers certificate of origin

Resolves #816

mikemhenry commented 5 months ago

testing here https://github.com/OpenFreeEnergy/openfe/actions/runs/8736309382

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.32%. Comparing base (e6b3d61) to head (3771d2b). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #831 +/- ## ======================================= Coverage 92.32% 92.32% ======================================= Files 134 134 Lines 9786 9786 ======================================= Hits 9035 9035 Misses 751 751 ``` | [Flag](https://app.codecov.io/gh/OpenFreeEnergy/openfe/pull/831/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenFreeEnergy) | Coverage Δ | | |---|---|---| | [fast-tests](https://app.codecov.io/gh/OpenFreeEnergy/openfe/pull/831/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenFreeEnergy) | `92.32% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenFreeEnergy#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mikemhenry commented 5 months ago

@richardjgowers this is ready to merge! I just removed the openfecli tests from CI, it has caught bugs before but I do not know why that test fails so I think we just remove those tests for now until we get them sorted out.

richardjgowers commented 5 months ago

@mikemhenry this is the CI on the docker build only right?

mikemhenry commented 5 months ago

Yes only for the docker building!