OpenFreeEnergy / openfe

The Open Free Energy toolkit
https://docs.openfree.energy
MIT License
124 stars 14 forks source link

pin macos runners to macos-12 #841

Closed mikemhenry closed 2 months ago

mikemhenry commented 2 months ago

Checklist

Developers certificate of origin

mikemhenry commented 2 months ago

I think we should make macos-latest not a required check until we get the missing deps onto conda-forge, but we should keep it in the build matrix.

We should make macos-13 a required check.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.32%. Comparing base (378147c) to head (059ceda).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #841 +/- ## ========================================== - Coverage 94.13% 92.32% -1.81% ========================================== Files 134 134 Lines 9786 9786 ========================================== - Hits 9212 9035 -177 - Misses 574 751 +177 ``` | [Flag](https://app.codecov.io/gh/OpenFreeEnergy/openfe/pull/841/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenFreeEnergy) | Coverage Δ | | |---|---|---| | [fast-tests](https://app.codecov.io/gh/OpenFreeEnergy/openfe/pull/841/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenFreeEnergy) | `92.32% <ø> (?)` | | | [slow-tests](https://app.codecov.io/gh/OpenFreeEnergy/openfe/pull/841/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenFreeEnergy) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenFreeEnergy#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mikemhenry commented 2 months ago

We got one missing dep, a weird package hash error, and a issue with ambertools/charge backend :)

IAlibay commented 2 months ago

@mikemhenry for the sake of "getting CI back and running today", let's go with just pinning to macos-13. I've opened a separate issue to deal with arm64-osx in a separate PR.