search

OpenFreeEnergy / openfe

The Open Free Energy toolkit
https://docs.openfree.energy
MIT License
124 stars 14 forks source link

[DNM] Test python 3.12 #850

Closed mikemhenry closed 1 month ago

mikemhenry commented 1 month ago

Checklist

Developers certificate of origin

pep8speaks commented 1 month ago

Hello @mikemhenry! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 253:5: E303 too many blank lines (2)

Comment last updated at 2024-05-10 19:40:45 UTC
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.28%. Comparing base (e8492ea) to head (3655ef1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #850 +/- ## ========================================== - Coverage 93.09% 92.28% -0.81% ========================================== Files 134 134 Lines 9708 9804 +96 ========================================== + Hits 9038 9048 +10 - Misses 670 756 +86 ``` | [Flag](https://app.codecov.io/gh/OpenFreeEnergy/openfe/pull/850/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenFreeEnergy) | Coverage Δ | | |---|---|---| | [fast-tests](https://app.codecov.io/gh/OpenFreeEnergy/openfe/pull/850/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenFreeEnergy) | `92.28% <100.00%> (?)` | | | [slow-tests](https://app.codecov.io/gh/OpenFreeEnergy/openfe/pull/850/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenFreeEnergy) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenFreeEnergy#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mikemhenry commented 1 month ago

okay it looks like because of https://github.com/OpenFreeEnergy/openfe/commit/56bd856136945ea56dae02298642f58a39776e27 we had a numpy<1.24 pin, but that was just in our env and not the conda package, so if we don't have any issues we should have python 3.12 support

mikemhenry commented 1 month ago

we just need https://github.com/conda-forge/citeproc-py-feedstock/pull/9 for osx-latest/osx-arm64 (or at least that is what is currently blocking that)

mikemhenry commented 1 month ago

Okay! So I learned we can support python 3.12 and we are maybe a PR away from supporting osx-arm64 in our CI