OpenFreeEnergy / openfe

The Open Free Energy toolkit
https://docs.openfree.energy
MIT License
124 stars 14 forks source link

add osx-arm64 py312 test #853

Closed mikemhenry closed 1 month ago

mikemhenry commented 1 month ago

Checklist

Developers certificate of origin

mikemhenry commented 1 month ago

Now that https://github.com/conda-forge/citeproc-py-feedstock/pull/9 is merged we should be able to run on osx-arm64

mikemhenry commented 1 month ago

Looks like the issue was with duecredit 0.10.0, not the new py-cite build that got merged :sweat_smile: (thought I broke the whole duecredit ecosystem)

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.28%. Comparing base (5be7f73) to head (21b589c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #853 +/- ## ========================================== - Coverage 94.05% 92.28% -1.77% ========================================== Files 134 134 Lines 9804 9804 ========================================== - Hits 9221 9048 -173 - Misses 583 756 +173 ``` | [Flag](https://app.codecov.io/gh/OpenFreeEnergy/openfe/pull/853/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenFreeEnergy) | Coverage Δ | | |---|---|---| | [fast-tests](https://app.codecov.io/gh/OpenFreeEnergy/openfe/pull/853/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenFreeEnergy) | `92.28% <ø> (?)` | | | [slow-tests](https://app.codecov.io/gh/OpenFreeEnergy/openfe/pull/853/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenFreeEnergy) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenFreeEnergy#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mikemhenry commented 1 month ago

:tada: we don't technically need the CONDA_SUBDIR=osx-64 anymore, but I think until we test like our notebooks or cli tutorial we should keep the work around in our docs.

mikemhenry commented 1 month ago

Since this is just expanding our testing matrix, I am going to merge this in

mikemhenry commented 1 month ago

OH and the latest version of duecredit seems broken, I've reported it upstream and fixed the pin https://github.com/duecredit/duecredit/pull/214