search

OpenFunscripter / OFS

A tool to create funscripts
GNU General Public License v3.0
90 stars 39 forks source link

Change waveform appearance #32

Closed Jimmy3111 closed 1 year ago

Jimmy3111 commented 2 years ago

My audio wave became this since don't know which version. image

Is there a way to force it back to this appearance? It is very hard for me to read the waveform with the new waveform appearance. image

OpenFunscripter commented 2 years ago

I don't thinkg it has anything to do with the new rendering. You can use the the scale factor to make things more visible. Capture

I used to normalize the samples before displaying them. Currently I'm just displaying them as they are. Normalizing can improve the default scale but it can also make it worse. 🤔

Ultimately it depends on the audio if it's all low frequency there's nothing to render.

OpenFunscripter commented 2 years ago

I added back the normalization. That way the default scale will be better in a lot of cases and in the ones where it isn't you'll have to manually tweak the scale either way.

Jimmy3111 commented 2 years ago

Thanks for adding the normalization back...

Jimmy3111 commented 2 years ago

Sorry, maybe I was not explaining my question clearly. After the update, I don't see any difference. (Maybe the scale is easier to adjust now? I am not sure what it means by normalization.) Scale is never the problem. What I was asking before is the look of the waveform. I make a comparison for two version of waveform at the same scale (5.0) and timestamp. Maybe it can help u understand my question easier.

As you can see, the waveform of the old version (1.3.0) shows more audio details. Also, it is very hard to see in the new version as the peak is so thick. They overlapped with each other.

image

image

Sorry for not explaining myself clearly and Thank you for adding normalization for me particularly. Pls consider adding the old waveform option in the next update if it is not too much trouble.

OpenFunscripter commented 2 years ago

I'm going to have another look. But I'm not bringing back the old style. That alone wouldn't do anything anyway since it would just display the data below in a different style.

The benchmark for how it looks shouldn't be OFS 1.3.0. Instead it should be some other program which I can trust to generate a "correct" waveform image.

There both approximations but I wonder which version above is closer to the "correct" image.

OpenFunscripter commented 2 years ago

I found the issue ... I used to call std::abs on all the samples since they can be negative.

Ideally the waveform would be asymmetrical but for now it will remain symetrical.