OpenFunscripter / OFS

A tool to create funscripts
GNU General Public License v3.0
90 stars 39 forks source link

Feature Request: Changing the unsaved changes dialog logic #42

Closed trassshhub closed 2 years ago

trassshhub commented 2 years ago

The current dialog in OFS on closing project/opening another project while unsaved changes is detected seems not to be in line with conventional logic.

Usually when an unsaved file is getting closed, the Yes/No/Cancel dialog would ask if the user would like to save the file or not: Yes - Save the changes and close No - Discard the changes and close Cancel - Don't close

The current OFS behavior does it the other way round and asks if the use would like to discard the changes: Yes - Discard the changes and close No - Don't close (but also won't save the changes) Cancel - Don't close which I find confusing.

Also, when drag'n droping another file into OFS when an unsaved project is present, it should be treated as trying to close the current project and load the dropped one. Therefore the same type of dialog shall be shown instead of an alert dialog with "The current project has unsaved edits.".

OpenFunscripter commented 2 years ago

This confuses me because when I test this it behaves like you expect.

Yes - Save the changes and close No - Discard the changes and close Cancel - Don't close

The drag'n drop thing can be changed.

trassshhub commented 2 years ago

These are the dialogs when you have unsaved edits. ofs

  1. Close current project/open another project
  2. Open project through the recent files
  3. Drag and drop file into OFS
  4. Close OFS by clicking the X button

only the last example follows what I expected.

OpenFunscripter commented 2 years ago

I didn't realize there were two yes/no/cancel dialogs. I changed the top one to be like the bottom one. And I added the bahaviour to the file dropping

trassshhub commented 2 years ago

Thanks for the fix, but I find that the second case (Open project through the recent files menu with unsaved edits) has not been resolved.

OpenFunscripter commented 2 years ago

Sorry I missed that