Github actions artifacts have broken mpv dll

OpenFunscripter / OFS

A tool to create funscripts

GNU General Public License v3.0

90 stars 39 forks source link

Github actions artifacts have broken mpv dll #60

Closed Yoooi0 closed 1 year ago

Yoooi0 commented 1 year ago

Recently noticed that all github action builds seem to contain a broken mpv-2.dll so they are not able to run. mpv-2.dll file contents:

version https://git-lfs.github.com/spec/v1
oid sha256:53cb89a50fc4c99b9f8b14fc1adbe55b78422b8fe2869519bddb88fb150c2643
size 79424512

OpenFunscripter commented 1 year ago

I'm aware of this. It's super annoying it requires a git lfs pull but the free 1GB github LFS bandwidth is used up... so it would fail either way. I will just include it back in the repository which is going to bloat the repo.

Yoooi0 commented 1 year ago

Maybe just download it in github actions from: https://sourceforge.net/projects/mpv-player-windows/files/libmpv/ Or as an alternative you could add auto mpv download on startup to OFS itself.

OpenFunscripter commented 1 year ago

I'll investigate if there's a ~~portable~~ way of downloading & extracting it via cmake. 🤔 Edit: This actually only needs to work on windows.

OpenFunscripter commented 1 year ago

This fixes the issue